Unify cli and script parsers #617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parser is intended tp replace both sic_parser and sic_cli_ops, unifying the parsing experience. This is intended to make it easier to add new image operations, removing duplication through the code base. As a disadvantage, we'll need to deal with two different input methods, which was the original reason two parsers exist: scripts in text form and cli ops through the cli interface. This commit has removed the cli_ops_parser, but the sic_parser is still in. Eventually, that one should also be removed. We will simultaneously develop and test both user facing interfaces, and should setup compatibility testing against the latest version which uses the old parsers.
foresterre
changed the title
duo
foresterre
changed the title
duo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parser is intended to replace both sic_parser and sic_cli_ops, unifying the parsing experience. This is intended to make it easier to add new image operations, removing duplication through the code base.
As a disadvantage, we'll need to deal with two different input methods, which was the original reason two parsers exist: scripts in text form and cli ops through the cli interface.
This commit has removed the cli_ops_parser, but the sic_parser is still in. Eventually, that one should also be removed. We will simultaneously develop and test both user facing interfaces, and should setup compatibility testing against the latest version which uses the old parsers.