Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firefox PIP/About to float #304

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Add Firefox PIP/About to float #304

merged 2 commits into from
Oct 31, 2023

Conversation

jmmaranan
Copy link
Collaborator

Closes #285

p1gp1g
p1gp1g reviewed Oct 27, 2023
View reviewed changes
config/windows.json Outdated Show resolved Hide resolved
@jmmaranan jmmaranan requested a review from p1gp1g October 31, 2023 02:52
@p1gp1g
Copy link
Contributor

p1gp1g commented Oct 31, 2023

It looks good to me. I've done the same for Thunerbird by the way:

{ "wmClass": "thunderbird", "wmTitle": "!Mozilla Thunderbird", "mode": "float" }

@jmmaranan jmmaranan merged commit 5600e95 into main Oct 31, 2023
2 checks passed
@jmmaranan jmmaranan deleted the fix-firefox-pip branch November 11, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p1gp1g p1gp1g p1gp1g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Firefox picture-in-picture should always float
2 participants
@jmmaranan @p1gp1g