Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork, Commit, Merge - Easy Issue (HTML) #535 & Fork, Commit, Merge - Medium Issue (HTML) #645 resolved #743

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

praptisharma28
Copy link
Contributor

@praptisharma28 praptisharma28 commented Sep 30, 2023

Description

Contact form updated along with a beautiful navigation bar with a flexible message box, hope you like it.

Screenshots of the contact form: https://yourimageshare.com/ib/XMSapn3jyj

https://yourimageshare.com/ib/quk9713JJH

Contact form updated along with a beautiful navigation bar with a flexible message box, hope you like it.
@praptisharma28 praptisharma28 changed the title Fork, Commit, Merge - Easy Issue (HTML) #535 resolved Fork, Commit, Merge - Easy Issue (HTML) #535 & Fork, Commit, Merge - Medium Issue (HTML) #645 resolved Sep 30, 2023
@pull-request-quantifier-deprecated

This PR has 134 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Medium
Size       : +118 -16
Percentile : 46.8%

Total files changed: 4

Change summary by file extension:
.py : +6 -5
.html : +112 -11

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@praptisharma28
Copy link
Contributor Author

Added Hello, World! to the path: http://127.0.0.1:8000/hello/ and resolved the issue- Fork, Commit, Merge - Easy Issue (Django) #725

Copy link
Member

@nikohoffren nikohoffren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, nicely done!

@nikohoffren nikohoffren merged commit 0ff72d0 into fork-commit-merge:main Oct 1, 2023
5 checks passed
@nikohoffren
Copy link
Member

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.

What's next?

If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.

Also please leave a star to this project if you feel it helped you, i would really appreciate it.

I look forward to seeing your contributions!

nikohoffren pushed a commit that referenced this pull request Oct 1, 2023
This reverts commit 0ff72d0, reversing
changes made to 12567e5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants