Skip to content

Commit

Permalink
feat(description): pass description through to settings scaffolder
Browse files Browse the repository at this point in the history
  • Loading branch information
travi committed Jul 7, 2024
1 parent c444b4f commit 8f3d65e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/scaffolder.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ import {scaffold as scaffoldSettings} from '@form8ion/repository-settings';
import {factory as getAuthenticatedOctokit} from './octokit/factory.js';
import {scaffold as scaffoldRepository} from './repository/index.js';

export default async function ({name, owner, visibility, projectRoot}) {
export default async function ({name, owner, visibility, description, projectRoot}) {
info('Initializing GitHub');

const octokit = getAuthenticatedOctokit();

const [repositoryResult] = await Promise.all([
scaffoldRepository({octokit, name, owner, visibility}),
fs.mkdir(`${projectRoot}/.github`, {recursive: true}),
scaffoldSettings({projectRoot, projectName: name, visibility})
scaffoldSettings({projectRoot, projectName: name, visibility, description})
]);

return {...repositoryResult};
Expand Down
6 changes: 4 additions & 2 deletions src/scaffolder.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ describe('scaffolder', () => {
const name = any.word();
const owner = any.word();
const visibility = any.word();
const description = any.sentence();
octokitFactory.mockReturnValue(octokitClient);
when(scaffoldRepository)
.calledWith({octokit: octokitClient, name, owner, visibility})
.mockResolvedValue(repositoryResult);

expect(await scaffold({name, owner, visibility, projectRoot})).toEqual({...repositoryResult});
expect(await scaffold({name, owner, visibility, projectRoot, description}))
.toEqual({...repositoryResult});
expect(fs.mkdir).toHaveBeenCalledWith(`${projectRoot}/.github`, {recursive: true});
expect(scaffoldSettings).toHaveBeenCalledWith({projectRoot, projectName: name, visibility});
expect(scaffoldSettings).toHaveBeenCalledWith({projectRoot, projectName: name, visibility, description});
});
});
4 changes: 3 additions & 1 deletion test/integration/features/step_definitions/common-steps.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Before(async function () {
({scaffold, test, lift} = await import('@form8ion/github'));

this.projectName = any.word();
this.projectDescription = any.sentence();
this.projectRoot = process.cwd();
});

Expand All @@ -36,7 +37,8 @@ When('the project is scaffolded', async function () {
projectRoot: this.projectRoot,
name: this.projectName,
owner: this.githubUser,
visibility: this.projectVisibility
visibility: this.projectVisibility,
description: this.projectDescription
});
} catch (err) {
debug(err);
Expand Down
4 changes: 1 addition & 3 deletions test/integration/features/step_definitions/settings-steps.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@ Then('repository settings are configured', async function () {
_extends: '.github',
repository: {
name: this.projectName,
// description: this.projectDescription,
// homepage: this.projectHomepage,
description: this.projectDescription,
private: 'Public' !== this.projectVisibility
// topics: this.topics.join(', ')
}
}
);
Expand Down

0 comments on commit 8f3d65e

Please sign in to comment.