Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote to stable #60

Merged
merged 18 commits into from
Aug 3, 2024
Merged

promote to stable #60

merged 18 commits into from
Aug 3, 2024

Conversation

travi
Copy link
Member

@travi travi commented Jul 30, 2024 •
edited
Loading

remaining tasks:

  • check for existing issue before creating new issue
  • tags should be additive within settings
  • homepage should not be removed from settings when not provided in lift results
  • export constants for prompt IDs and field names
  • update docs to match public API changes
  • coordinated release with promote to stable project#1668

follow-up:

travi and others added 9 commits July 29, 2024 14:16
@travi
feat(vcs): nested repository-details under the vcs results object
75ccb59 
BREAKING CHANGE: repository details are now nested under the `vcs` results object
@travi
feat(project-name): expect project-name as input rather than reposito…
eea11e0 
…ry-name

to give flexibility for the hosted repository name to be decided within the plugin, but with the
ability to be influenced by the project name

BREAKING CHANGE: `projectName` is expected as input instead of `name`, which previously meant
repository name
@travi
feat(repository-name): return the name of the created repository as p…
0b30aeb 
…art of vcs results
@renovate
chore(deps): update dependency husky to v9.1.4
aedf6f5
@travi
feat(host): set the host detail in the vcs results
3d327b1
@travi
feat(owner): return the provided owner as a vcs result detail
594afde
@travi
feat(account): owner is no longer accepted as scaffolder input, promp…
524bf14 
…t for it instead

BREAKING CHANGE: vcs-host account is no longer accepted as the `owner` input to the scaffolder.
instead the `prompt` dependency is required and is used to prompt for this detail as input
@travi
fix(deps): updated the core package and verified plugin compatibility…
ddf6c48 
… w/ the form8ion plugin schema
@travi
Merge pull request #57 from form8ion/alpha
1e7df42
@socket-security Socket Security
Copy link

socket-security bot commented Jul 30, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@form8ion/[email protected] filesystem +7 780 kB form8ion-bot
npm/@form8ion/[email protected] None 0 16.5 kB form8ion-bot

🚮 Removed packages: npm/@form8ion/[email protected], npm/@form8ion/[email protected]

View full report↗︎

@travi
Copy link
Member Author

travi commented Jul 30, 2024 •
edited
Loading

  • check for existing issue before creating new issue

it looks like lifting doesnt yet result in duplicates, so i think this could be delayed until after promoting this (#37)

@travi
Copy link
Member Author

travi commented Aug 1, 2024

  • tags should be additive within settings

this isnt really a problem until results start including tags when lifting, so i'm ok with delaying (#69)

@travi travi marked this pull request as ready for review August 3, 2024 22:08
@travi travi merged commit 5aeae5d into master Aug 3, 2024
10 checks passed
@travi travi deleted the beta branch August 3, 2024 22:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2024

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released This issue or pull-request was included in a version released by semantic-release label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This issue or pull-request was included in a version released by semantic-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@travi