Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overdraft function #14

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ascandone
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 62.68%. Comparing base (ce58d0f) to head (f62e3db).

Files with missing lines Patch % Lines
internal/interpreter/interpreter.go 66.66% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #14      +/-   ##
==========================================
+ Coverage   62.65%   62.68%   +0.02%     
==========================================
  Files          28       28              
  Lines        6041     6078      +37     
==========================================
+ Hits         3785     3810      +25     
- Misses       2096     2104       +8     
- Partials      160      164       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ascandone
Copy link
Contributor Author

It turns out I couldn't call this function overdraft because that is already a token.
So we would need to use something like overdraft_amount instead (or workaround this issue, which I'm not sure is a good idea)

Base automatically changed from dev to main October 29, 2024 08:59
@ascandone ascandone changed the title draft implementation feat: overdraft function Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant