Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Expose kafka messages models and bump dependencies #27

Merged
merged 10 commits into from
Aug 29, 2022

Conversation

antoinegelloz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #27 (857243a) into main (7324b05) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Current head 857243a differs from pull request most recent head 0c131f0. Consider uploading reports for the commit 0c131f0 to get more accurate results

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   28.28%   28.18%   -0.11%     
==========================================
  Files          40       41       +1     
  Lines        2174     2182       +8     
==========================================
  Hits          615      615              
- Misses       1491     1499       +8     
  Partials       68       68              
Impacted Files Coverage Δ
pkg/api/http.go 0.00% <0.00%> (ø)
pkg/bridge/cdi/module.go 0.00% <0.00%> (ø)
pkg/bridge/ingestion/ingester.go 56.96% <0.00%> (+1.40%) ⬆️
pkg/bridge/ingestion/message.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@antoinegelloz antoinegelloz changed the title refactor: Move kafka messages models to sharedpublishkafka chore: Expose kafka messages models and bump dependencies Aug 26, 2022
Copy link
Contributor

@gfyrag gfyrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove core package, code was fine where it was.

Imports give "payments.Payment{}" which is pretty better import path than "core.Payment{}".

Even, if we change that, it is not the goal of this PR and there are no subject on this service actually.

@antoinegelloz antoinegelloz merged commit 7c1234a into main Aug 29, 2022
@antoinegelloz antoinegelloz deleted the refactor/move-models-to-sharedpublishkafka branch August 29, 2022 10:09
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants