chore: upgrade to latest go-libs #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyrag
force-pushed
the
feat/num-1050-payments-update-go-libs-to-last-version
branch
from
e79c6cc
to
224b8ee
Compare
gfyrag
commented
Nov 23, 2022
| root.Flags().Bool(publisherKafkaEnabledFlag, false, "Publish write events to kafka") | ||
| root.Flags().StringSlice(publisherKafkaBrokerFlag, []string{}, "Kafka address is kafka enabled") | ||
| root.Flags().StringSlice(publisherTopicMappingFlag, | ||
| server.Flags().BoolP("toggle", "t", false, "Help message for toggle") |
There was a problem hiding this comment.
Set flags on server command and not un root command.
gfyrag
commented
Nov 23, 2022
| false, "Use scopes as defined by rfc https://datatracker.ietf.org/doc/html/rfc8693") | ||
|
|
||
| sharedotlptraces.InitOTLPTracesFlags(server.Flags()) |
There was a problem hiding this comment.
Library now automatically setup flags.
gfyrag
force-pushed
the
feat/num-1050-payments-update-go-libs-to-last-version
branch
from
224b8ee
to
8447e4c
Compare
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 24.34% 24.45% +0.10%
==========================================
Files 87 87
Lines 4140 4147 +7
==========================================
+ Hits 1008 1014 +6
- Misses 3038 3039 +1
Partials 94 94
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
also add pre-commit config
gfyrag
force-pushed
the
feat/num-1050-payments-update-go-libs-to-last-version
branch
from
8447e4c
to
a7d0c9b
Compare
flemzord
approved these changes
Nov 25, 2022
antoinegelloz
approved these changes
Nov 28, 2022
antoinegelloz
deleted the
feat/num-1050-payments-update-go-libs-to-last-version
branch
flemzord
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go-libs to last version.
Also use github.com/formancehq/go-libs import path instead of github.com/numary/go-libs.
Changes also add pre-commit config.
Other changes are caused by the linter on pre-commit which remove trailing spaces on files.
Also, fix a little "bug" on flags which was defined on root command instead of the "server" command.