Skip to content
This repository has been archived by the owner on Apr 30, 2018. It is now read-only.

Improve multi-checkbox required #26

Closed
kentcdodds opened this issue Jun 3, 2015 · 3 comments
Closed

Improve multi-checkbox required #26

kentcdodds opened this issue Jun 3, 2015 · 3 comments

Comments

@kentcdodds
Copy link
Member

Moved from formly-js/angular-formly#330

Original issue by @PhilFlash:

Hi,
Error is incorrect when you use a multicheckbox and option required.
See example:
http://plnkr.co/edit/IleV3U8AVY0Va3lbmUve?p=info

Steps to reproduce:

  • step 1 : check Travel and uncheck Travel (last checkbox) => there is an error : Type is required : field is in red : all is ok
  • step 2 : check Research => the field Type is in error : BUG

Only the last checkbox is used to check 'Required'
@kentcdodds kentcdodds mentioned this issue Jun 3, 2015
Closed
ckniffen pushed a commit to ckniffen/angular-formly-templates-bootstrap that referenced this issue Jun 8, 2015
Required type validation only worked for the last checkbox.
08d4fbe 
Fixes formly-js#26
ckniffen pushed a commit to ckniffen/angular-formly-templates-bootstrap that referenced this issue Jun 11, 2015
Required type validation only worked for the last checkbox.
416b485 
Fixes formly-js#26
@ckniffen ckniffen mentioned this issue Jun 11, 2015
Merged
@kentcdodds
Copy link
Member Author

Thanks to @ckniffen, this has been fixed and released in 4.3.2

@kentcdodds
Copy link
Member Author

cc/ @PhilFlash fixed in 4.3.2 :-)

@PhilFlash
Copy link

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kentcdodds @PhilFlash