Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual inconsistency + font too dark on moon widget #744

Open
gusio opened this issue Nov 13, 2023 · 5 comments
Open

Visual inconsistency + font too dark on moon widget #744

gusio opened this issue Nov 13, 2023 · 5 comments
Labels
Milestone

Comments

@gusio
Copy link

gusio commented Nov 13, 2023

Hi,

I noticed two visual 'bugs':

  1. Golden hour colors seem switched. I think golden hour start should follow the sunrise/sunset column logic - yellow for sunrise and orange for sunset. Another way would be to set them both to orange ('golden'). Screenshot 1.

  2. The moon phase name in moon widget (2x1) in dark themes is almost invisible - a lighter colour would be better. Screenshot 2.

  • App Version: 0.15.8
  • Android Version: 14
  • Device Model: Pixel 5

Thanks for an amazing app !!!!

Screenshot 1.png

Screenshot 2.png

@gusio
Copy link
Author

gusio commented Nov 13, 2023

Now that I think of it I guess that the font color for the moon phase name is dynamic and the new moon which I happened to notice should be darker than full moon or anything in between - still a notch lighter would help 😀

@forrestguice
Copy link
Owner

Thanks for the feedback.

That moon color is dynamic, but we can tweak the default themes to improve contrast.
It should follow the "new moon" theme color (so it should also be possible to override by creating a custom widget theme).

I'm on the fence about swapping the golden hour colors (also applied to blue hour).
In the morning the gold hour time is an ending time (starts at civil twilight), and in the evening a starting time, a reverse from the other times in the column. That is the reason for the current coloring. However, I kind of doubt many people make that connection, or if it helps understanding in any way.

btw, the "high contrast" app themes do away with the yellow/orange coloring and opt for shades of gray.

@naoliv
Copy link
Contributor

naoliv commented Nov 26, 2023

While at it, if we click here:

Then this feels dark too (for me, at least):

If we click here:

Then this is too dark:

@naoliv
Copy link
Contributor

naoliv commented Nov 27, 2023

On Themes too:

@gusio
Copy link
Author

gusio commented Nov 27, 2023 via email

forrestguice added a commit that referenced this issue Dec 4, 2023
moon phase text colors; fixes readability of moon phase text in widgets (#744)
forrestguice added a commit that referenced this issue Dec 4, 2023
improves contrast (#744)
@forrestguice forrestguice added this to the v0.15.9 milestone Dec 4, 2023
forrestguice added a commit that referenced this issue Dec 8, 2023
moon phase text colors; fixes readability of moon phase text in widgets (#744)
forrestguice added a commit that referenced this issue Dec 8, 2023
improves contrast (#744)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants