Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Places #785

Open
islam2hamy opened this issue Mar 21, 2024 · 2 comments
Open

[Feature request] Places #785

islam2hamy opened this issue Mar 21, 2024 · 2 comments

Comments

@islam2hamy
Copy link

Hello,

Could you please add Africa and Middle East to places

Thank you

forrestguice added a commit that referenced this issue Apr 9, 2024
adds places.xml resource file (contains default places sorted by continent) (#785)
forrestguice added a commit that referenced this issue Apr 9, 2024
refactors "add world places" to use `place_group` resources (#785)
forrestguice added a commit that referenced this issue Apr 9, 2024
adds world places (#785)
@forrestguice forrestguice mentioned this issue Apr 9, 2024
@forrestguice
Copy link
Owner

forrestguice commented Apr 10, 2024

The next patch adds to places, but its still a work in progress. I've organized the existing defaults by continent in 8f1bc31, and started adding new places in 2abac4a.

The list was original tied to different locale defaults (each city represents some language), which is one reason why the distribution isn't even (a lot of places in Europe, practically none in North America). Another reason for gaps is because the list is manually created. I add cities one at a time, read about them on wiki, then look at map imagery to pick out coordinates (in some public location like a park, beach, or university grounds). I think that's kind of fun.

I think a reasonable goal is at least one city per country, and then additional cities by population. If a particular region is bare though we can add other places; e.g. I've added stations in Antarctica just for fun.

@islam2hamy
Copy link
Author

Appreciate your effort

I think a reasonable goal is at least one city per country, and then additional cities by population

agree with you
thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants