Implement image cleanup and separate it from bot teardown #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
canercidam
commented
Aug 19, 2023
•
canercidam
commented
- No more removing images in the teardown method
- Implemented separate image cleanup:
- The supervisor runs the cleanup every minute but the cleanup really executes only every hour.
- The cleanup accepts an exclusion list (helps us exclude heartbeat).
- If any image is not a Disco image, it is skipped.
- If any image is in use by any container (whether it's up or down), it is skipped.
stevenlanders
approved these changes
Aug 21, 2023
canercidam
deleted the
caner/forta-1216-remove-images-less-aggressively
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.