Inject sdk cache configuration to agents #856
Conversation
| // These values will be injected into the agent container to configure SDK | ||
| // SDKRequestTimeout timeout until the SDK must fallback to the RPC Node | ||
| // Value in seconds and can be a float. | ||
| SDKRequestTimeout = "5" |
There was a problem hiding this comment.
I would rename this to SDKRequestTimeoutSeconds and make it 20 if the chain data bucket interval is 10s. Also I think I would exclude the word SDK from any naming - the bot could be based on anything. Maybe BotCacheRequestTimeout kind of naming could be used.
There was a problem hiding this comment.
Good point. Fixed. Thanks
| SDKRequestTimeout = "5" | ||
| // SDKRequestInterval interval between SDK requests | ||
| // Value in seconds and can be a float. | ||
| SDKRequestInterval = "1" |
There was a problem hiding this comment.
Let's append Seconds to the name.
There was a problem hiding this comment.
Good point. Fixed. Thanks
config/env.go
Outdated
|
|
||
| EnvJsonRpcHost = "JSON_RPC_HOST" | ||
| EnvJsonRpcPort = "JSON_RPC_PORT" | ||
| EnvCacheJsonRpcCachePort = "CACHE_JSON_RPC_PORT" |
There was a problem hiding this comment.
Can we prefix all of these new cache env vars like JSON_RPC_CACHE_*? E.g. JSON_RPC_CACHE_PORT, JSON_RPC_CACHE_REQUEST_TIMEOUT etc. Prefixing with CACHE could be confusing if we introduce another cache for the bots to use.
There was a problem hiding this comment.
Good point. Fixed. Thanks
dkeysil
force-pushed
the
kisel/forta-1608-inject-caching-configuration-to-bots
branch
from
e3386d5
to
62efc2b
Compare
dkeysil
merged commit ce1e967
into
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
dkeysil
deleted the
kisel/forta-1608-inject-caching-configuration-to-bots
branch
No description provided.