refactor: split out modules for separate concerns #172
+3,607
−2,623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* organize the codebase into modules * use absolute instead of relative imports * no need for classes to inherit from object * use consistent camel case for class names * remove imports from __future__ from test script (not needed) * run black and isort on python files * add .DS_Store to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object__future__from test script (not needed)blackandisorton python files (responsible for LOC increase).DS_Storeto.gitignoreThis should not introduce any functional changes — see passing tests on my fork
todo: tests to pytest