include mkl libraries for intel compiler on linux and macOS #72

iulusoy · 2024-03-14T20:33:29Z

Add math library support with the new keyword install_mkl.

include mkl libraries for all intel compiler versions on linux
include mkl libraries for all ìntel-classic` versions on macOS EXCEPT version 2021.5
- for some reason, installing the intel base-kit alongside the hpc-kit breaks the compiler set-up for version 2021.5
- the exporting of DYLD_LIBRARY_PATH arbitrarily works on some runners and not on others, randomly fails for some version. If it is exported manually in the github action by setting it to $MKLLIB, the linking of the libraries works though. I could not test this much as the only macs I have for testing are the GitHub runners.

Initially I had wanted to only support linux. But then I tried to include mkl also for macOS - I consider this a starting point for future improvement. I am unfamiliar with windows, and the Fortran code I am working with has not been tested on Windows so far, so I did not include it.

Ideally, one would also want to install BLAS and LAPACK for the gnu compiler suite.

mpi support was also mentioned in #55

* also install intel mkl libraries in apt * trigger checks * trigger checks

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* add version number to apt mkl install * hpc basekit for macos

* info-on-mac * set mkl version explicitly * more debug on mac * fix variable typo for linux mkl version * only test on ubuntu * matrix * matrix * fix version selection * check both classic and new * verify dmg * check hpckit * check hpckit * restrict basekit versions * pass install_mkl and test mkl * set input in main action * set input in main action * set input in script * fix typo * change linker options * source env * export DYLD path for Mac * include explicit library path in linker * export mklroot in script * export mklroot to GH env * export mklroot to GH env * export mklroot in script * correct typo * another typo * debug env vars * debug env vars * debug env vars * debug env vars * debug env vars * debug env vars * debug env vars * debug env vars * typo and relative reference mklroot * debug mklroot path * debug mklroot path * typo * find include dir * find include dir * debug mac os dyld path * check all ubuntu * no mkl for gcc and nvidia-hpc * mkl lates * check compiler vars * mkl dir for macos * debug * debug * adapt test structure * remove double testing * conditional in bash * conditional in bash * conditional in bash * conditional in bash * typo * pass missing variable * test them all * test them all * check macos mkl path * set full library path in script * export DYLD in env * test them all * exclude mkl tests on windows * exclude mkl tests on windows * check for dyld * rename mkllib in gh env * shuffle version mapping for mac * export DYLD in script * shuffle mkl version numbers * find installed mkl version * try without mkl * try without mkl * find installed mkl version * find installed mkl version * shuffle mkl vs ifort version * find mkl for 2021.5 * skip mkl for 2021.5 macos and remove double export of dyld * less chatty, .5 exception * last changes? * test 2021.5 only * test them all * export dyld in action

* correct passsing of include_mkl in example * don't source intel set vars * run setvars, set MKLLIB

* feat: set FPM environment variables (fortran-lang#63) * set FPM_FC/FPM_CC/FPM_CXX matching FC/CC/CXX * consolidate env var assignment in setup script * feat: support intel 2024.0 on linux and windows (fortran-lang#64) * fix(mac/gcc): always create unversioned gcc/g++/gfortran links (fortran-lang#65) * brew doesn't link gcc/g++ without version number like it does for gfortran * this was causing default mac gcc/g++ to be discovered on PATH * fix readme auto-update PR conditionals in reporting mode * Update compatibility matrix (fortran-lang#66) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * ci: don't trigger when tags are pushed (fortran-lang#67) * correct typo * fix variable name * pass cpp_name * pass cpp_name --------- Co-authored-by: wpbonelli <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

setup-fortran.sh

wpbonelli · 2024-03-16T01:36:55Z

thanks for this @iulusoy I think if we can also support windows, we might as well include mkl by default and not have a separate input? it might be tricky to find the oneAPI basekit links for older versions, it is unfortunate that mkl is not in the hpckit

iulusoy · 2024-03-18T10:40:30Z

Unfortunately I have no experience with windows, I can try but it will have to be in three-four weeks.

move macos mkl install into separate script move variable export to main calling function set lib env export in action source instead of execute set MKLLIB per case, skip 2021.5 macos mkl

iulusoy · 2024-03-20T07:39:20Z

Incorporated the requested changes so far, could you please re-review @wpbonelli ?
Windows not incorporated yet.

install-mkl-macos.sh

.github/compat/long_compat.csv

.github/actions/test-fc/action.yml

wpbonelli · 2024-03-20T17:09:11Z

test/hw_mkl.f90

@@ -0,0 +1,13 @@
+program hello


It's good to include math ops in the test program. If we include mkl by default, we can just roll this into the existing fortran test program/action.

Yes, but that would also require installing BLAS/LAPACK for the gnu compilers - for now I would leave it separate, and make the optional math library install the default version once there is something for all compilers/OS.

action.yml

wpbonelli · 2024-03-20T18:01:15Z

thanks @iulusoy. I might take a shot at Windows if I have a chance in the meantime

…ct compatibility

iulusoy · 2024-03-27T12:45:42Z

Addressed the comments, imo the next steps would be (if math libraries are to be installed as default):

include mkl install for Windows
include BLAS/LAPACK install for gnu compilers: Linux, MacOS, Windows
I would suggest doing those in separate PRs to minimize complexity.

wpbonelli · 2024-03-27T14:50:22Z

@iulusoy yes, we'd also want to look at nvidia and lfortran too. Agreed on keeping PRs small. I think a lot of people use @main instead of the tags so I think it's best to wait for all platforms/toolchains before merging here. I made a math branch we can use for prototyping, if you want to move this PR over there?

iulusoy and others added 12 commits September 13, 2023 14:09

install intel mkl libraries in addition to the compiler (#1)

56f36a1

* also install intel mkl libraries in apt * trigger checks * trigger checks

Update action.yml

adbf96a

Update compatibility matrix (#3)

f731ad7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update compatibility matrix (#2)

687069d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

V0 (#4)

81c4847

* add version number to apt mkl install * hpc basekit for macos

merge

3dacbb4

Merge branch 'fortran-lang-main'

2b7dceb

Merge branch 'fortran-lang:main' into main

d712ae0

Check usage of marketplace action (#7)

3b77edb

* correct passsing of include_mkl in example * don't source intel set vars * run setvars, set MKLLIB

Merge branch 'main' into create-PR-and-sync

428a567

wpbonelli reviewed Mar 15, 2024

View reviewed changes

setup-fortran.sh Outdated Show resolved Hide resolved

wpbonelli reviewed Mar 15, 2024

View reviewed changes

setup-fortran.sh Outdated Show resolved Hide resolved

wpbonelli reviewed Mar 15, 2024

View reviewed changes

setup-fortran.sh Outdated Show resolved Hide resolved

removed source setvars and manipulation of DYLD_LIBRARY_PATH

0e8b621

move macos mkl install into separate script move variable export to main calling function set lib env export in action source instead of execute set MKLLIB per case, skip 2021.5 macos mkl

iulusoy force-pushed the create-PR-and-sync branch from 16a5dc6 to 0e8b621 Compare March 20, 2024 07:35

wpbonelli reviewed Mar 20, 2024

View reviewed changes

install-mkl-macos.sh Outdated Show resolved Hide resolved

wpbonelli reviewed Mar 20, 2024

View reviewed changes

.github/compat/long_compat.csv Outdated Show resolved Hide resolved

wpbonelli reviewed Mar 20, 2024

View reviewed changes

.github/actions/test-fc/action.yml Outdated Show resolved Hide resolved

wpbonelli reviewed Mar 20, 2024

View reviewed changes

action.yml Show resolved Hide resolved

iulusoy added 4 commits March 27, 2024 08:43

use macos install script for both dmgs, answer y in apt install for a…

2e936a9

…ct compatibility

remove accidental duplication

940e8cb

reverse order of passed variables in case string is empty

847d447

remove pasted garbage in link

c594266

iulusoy added 5 commits March 27, 2024 11:55

rename macos install script

dc2ccc7

try wo another export of MKLLIB in the action.yml

0bcfd2f

Merge branch 'main' into create-PR-and-sync

2e74f55

export mkllib in test

67c9148

no latest when using MKLROOT for macos

9a69df5

Merge branch 'main' into create-PR-and-sync

6894565

iulusoy closed this Mar 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

include mkl libraries for intel compiler on linux and macOS #72

include mkl libraries for intel compiler on linux and macOS #72

iulusoy commented Mar 14, 2024

wpbonelli commented Mar 16, 2024 •

edited

Loading

iulusoy commented Mar 18, 2024

iulusoy commented Mar 20, 2024

wpbonelli Mar 20, 2024

iulusoy Mar 27, 2024

wpbonelli commented Mar 20, 2024

iulusoy commented Mar 27, 2024 •

edited

Loading

wpbonelli commented Mar 27, 2024 •

edited

Loading

include mkl libraries for intel compiler on linux and macOS #72

include mkl libraries for intel compiler on linux and macOS #72

Conversation

iulusoy commented Mar 14, 2024

wpbonelli commented Mar 16, 2024 • edited Loading

iulusoy commented Mar 18, 2024

iulusoy commented Mar 20, 2024

wpbonelli Mar 20, 2024

Choose a reason for hiding this comment

iulusoy Mar 27, 2024

Choose a reason for hiding this comment

wpbonelli commented Mar 20, 2024

iulusoy commented Mar 27, 2024 • edited Loading

wpbonelli commented Mar 27, 2024 • edited Loading

wpbonelli commented Mar 16, 2024 •

edited

Loading

iulusoy commented Mar 27, 2024 •

edited

Loading

wpbonelli commented Mar 27, 2024 •

edited

Loading