Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linalg: enable 80-bit extended precision for whole library, xdp #839

Merged
merged 14 commits into from
Jul 4, 2024

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Jun 23, 2024

Enable xdp precision for BLAS, LAPACK and whole linear algebra library.
This PR now seamlessly enables both 80-bit extended-precision (xdp) and 128-bit quadruple precision (qp) versions of the liear algebra library to be built.

  • extended precision functions templated for whole blas, lapack
  • new initials defined:

real entities -> s, d, x, q
complex entities -> c, z, y, w

  • whole functionality including BLAS/LAPACK interfaces, as well as the whole testsuite, have now removed the constraints to not use xdp.
  • both "high" precision LAPACK modules share use of 64-bit double precision for the algorithms that require a "lower precision" kind

cc: @jvdp1 @jalvesz @fortran-lang/stdlib

@perazz perazz requested review from jvdp1 and removed request for jvdp1 June 23, 2024 18:50
@perazz perazz marked this pull request as ready for review June 23, 2024 18:51
@jvdp1 jvdp1 mentioned this pull request Jul 2, 2024
7 tasks
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending a minor comment, it could be merged IMO. It is probably better to merge this one and then review #828 and #832 in light of this PR.

src/stdlib_linalg_lapack_aux.fypp Outdated Show resolved Hide resolved
test/linalg/test_blas_lapack.fypp Show resolved Hide resolved
@perazz
Copy link
Contributor Author

perazz commented Jul 2, 2024

Thanks a lot for the review @jvdp1. I agree: if we get to merge this PR first, then I can add xdp support back into the outstanding PRs, before merging them.

@jalvesz
Copy link
Contributor

jalvesz commented Jul 2, 2024

LGTM @perazz! It would indeed be good to merge this PR before moving to the pending linalg ones.

@perazz
Copy link
Contributor Author

perazz commented Jul 2, 2024

Sounds like a good plan @jvdp1 @jalvesz. Let’s wait until tomorrow, and then merge this o e if there are no further comments.

@perazz
Copy link
Contributor Author

perazz commented Jul 4, 2024

Thank you @jvdp1 @jalvesz, merging.

@perazz perazz merged commit 4859081 into fortran-lang:master Jul 4, 2024
17 checks passed
@perazz perazz deleted the linalg_xdp branch July 4, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants