fix: fixed socket check (returning false positive)

forwardemail · Oct 10, 2024 · 7f57edb · 7f57edb
1 parent 64e2c44
commit 7f57edb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/helpers/on-auth.js b/helpers/on-auth.js
@@ -66,8 +66,14 @@ async function onAuth(auth, session, fn) {
     if (this.server instanceof IMAPServer) {
       const socket =
         (session.socket && session.socket._parent) || session.socket;
-      if (!socket || socket?.destroyed || socket?.readyState !== 'open')
-        throw new SocketError();
+      if (!socket || socket?.destroyed || socket?.readyState !== 'open') {
+        const err = new SocketError();
+        err.isCodeBug = true;
+        err.socket = socket;
+        err.session = session;
+        this.logger.fatal(err);
+        // throw err; // TODO: investigate why socket error occurs here
+      }
     }
 
     // override session.getQueryResponse (safeguard)

diff --git a/helpers/refresh-session.js b/helpers/refresh-session.js
@@ -57,8 +57,14 @@ async function refreshSession(session, command) {
     this?.constructor?.name !== 'CalDAV'
   ) {
     const socket = (session.socket && session.socket._parent) || session.socket;
-    if (!socket || socket?.destroyed || socket?.readyState !== 'open')
-      throw new SocketError();
+    if (!socket || socket?.destroyed || socket?.readyState !== 'open') {
+      const err = new SocketError();
+      err.isCodeBug = true;
+      err.socket = socket;
+      err.session = session;
+      this.logger.fatal(err);
+      // throw err; // TODO: investigate why socket error occurs here
+    }
   }
 
   if (!isSANB(session?.user?.domain_id) || !isSANB(session?.user?.domain_name))