-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite2 #27
Merged
Merged
Rewrite2 #27
Commits on Jun 4, 2018
-
Draft new workflow in reference2.md
The existing workflow suggests using error prone commands such as `git rebase`. This workflow avoids such commands and tries to infuse other best practices.
Configuration menu - View commit details
-
Copy full SHA for 9bd269c - Browse repository at this point
Copy the full SHA 9bd269cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 069359a - Browse repository at this point
Copy the full SHA 069359aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6999f4a - Browse repository at this point
Copy the full SHA 6999f4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5976c26 - Browse repository at this point
Copy the full SHA 5976c26View commit details -
- Add a horizontal rule before details section - Add bold to note at the top - Remove meta comment at the top
Configuration menu - View commit details
-
Copy full SHA for 6c940a7 - Browse repository at this point
Copy the full SHA 6c940a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fb8547 - Browse repository at this point
Copy the full SHA 6fb8547View commit details
Commits on Jun 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 275894f - Browse repository at this point
Copy the full SHA 275894fView commit details -
Significant changes to activity and minor to roles
- Remove squash since this can be done by the maintainer when accepting a pull-request. - Move multi-round before conflict since it is easier and gives participants a chance to practice the basic workflow before having to deal with a conflict. - Minor renames in contributor.md.
Configuration menu - View commit details
-
Copy full SHA for d388311 - Browse repository at this point
Copy the full SHA d388311View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc54af2 - Browse repository at this point
Copy the full SHA dc54af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb29f84 - Browse repository at this point
Copy the full SHA fb29f84View commit details -
Configuration menu - View commit details
-
Copy full SHA for b12eb40 - Browse repository at this point
Copy the full SHA b12eb40View commit details -
Configuration menu - View commit details
-
Copy full SHA for e148127 - Browse repository at this point
Copy the full SHA e148127View commit details
Commits on Jun 7, 2018
-
Push changes now pushes all branches
Push changes is used during work and during cleanup. We're on different branches in each case (feature and master). Rather than specifying each explicitly (`git push origin master` and `git push origin FEATURE_BRANCH`) or asking folks to figure out which branch needs pushing (`git push origin BRANCH_THAT_NEEDS_PUSHING`), we will have them push up all branches with `git push`. It is usually considered best practice not to push all branches in case you are midway through a change in a branch that you don't want pushed. But at this stage, it overcomplicates things.
Configuration menu - View commit details
-
Copy full SHA for 583a899 - Browse repository at this point
Copy the full SHA 583a899View commit details -
I changed my mind from the last commit. Rather than use `git push`, wanting to use the best practice of specifying the remote and branch in a push, and believing that students will learn parallel forms faster than variations, I have made two recipes for push: one for pushing the feature branch, and one for pushing master.
Configuration menu - View commit details
-
Copy full SHA for 2eebb9d - Browse repository at this point
Copy the full SHA 2eebb9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d53545 - Browse repository at this point
Copy the full SHA 3d53545View commit details -
Add push master to update master recipe
The goal is to synchronize master with our repositories. So we need to push to origin after pulling from upstream.
Configuration menu - View commit details
-
Copy full SHA for 1fcc267 - Browse repository at this point
Copy the full SHA 1fcc267View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5202e0d - Browse repository at this point
Copy the full SHA 5202e0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2dd933 - Browse repository at this point
Copy the full SHA e2dd933View commit details -
Configuration menu - View commit details
-
Copy full SHA for a401b2e - Browse repository at this point
Copy the full SHA a401b2eView commit details -
From burged The formation of teams was already a bullet item in the README -- maybe pull that bulleted item from the README -- it makes more sense for the formation of teams to be here.
Configuration menu - View commit details
-
Copy full SHA for c291f84 - Browse repository at this point
Copy the full SHA c291f84View commit details -
Configuration menu - View commit details
-
Copy full SHA for adae2ca - Browse repository at this point
Copy the full SHA adae2caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d9feda - Browse repository at this point
Copy the full SHA 5d9fedaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d76b23b - Browse repository at this point
Copy the full SHA d76b23bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc7ef82 - Browse repository at this point
Copy the full SHA bc7ef82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b99215 - Browse repository at this point
Copy the full SHA 5b99215View commit details
Commits on Jun 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 769d30f - Browse repository at this point
Copy the full SHA 769d30fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1162d97 - Browse repository at this point
Copy the full SHA 1162d97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c8f34c - Browse repository at this point
Copy the full SHA 4c8f34cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 921c98f - Browse repository at this point
Copy the full SHA 921c98fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.