Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite2 #27

Merged
merged 29 commits into from
Jun 8, 2018
Merged

Rewrite2 #27

merged 29 commits into from
Jun 8, 2018

Commits on Jun 4, 2018

  1. Draft new workflow in reference2.md

    The existing workflow suggests using error prone commands such
    as `git rebase`. This workflow avoids such commands and tries
    to infuse other best practices.
    StoneyJackson committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    9bd269c View commit details
    Browse the repository at this point in the history
  2. Fix internal links

    StoneyJackson committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    069359a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6999f4a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5976c26 View commit details
    Browse the repository at this point in the history
  5. Adjust style slightly

    - Add a horizontal rule before details section
    - Add bold to note at the top
    - Remove meta comment at the top
    StoneyJackson committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    6c940a7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6fb8547 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2018

  1. Configuration menu
    Copy the full SHA
    275894f View commit details
    Browse the repository at this point in the history
  2. Significant changes to activity and minor to roles

    - Remove squash since this can be done by the maintainer
      when accepting a pull-request.
    - Move multi-round before conflict since it is easier
      and gives participants a chance to practice the basic
      workflow before having to deal with a conflict.
    - Minor renames in contributor.md.
    StoneyJackson committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    d388311 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc54af2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fb29f84 View commit details
    Browse the repository at this point in the history
  5. Update presentation

    StoneyJackson committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    b12eb40 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e148127 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. Push changes now pushes all branches

    Push changes is used during work and during cleanup. We're on different branches in each case (feature and master). Rather than specifying each explicitly (`git push origin master` and `git push origin FEATURE_BRANCH`) or asking folks to figure out which branch needs pushing (`git push origin BRANCH_THAT_NEEDS_PUSHING`), we will have them push up all branches with `git push`. It is usually considered best practice not to push all branches in case you are midway through a change in a branch that you don't want pushed. But at this stage, it overcomplicates things.
    StoneyJackson authored Jun 7, 2018
    Configuration menu
    Copy the full SHA
    583a899 View commit details
    Browse the repository at this point in the history
  2. Make two recipes for push

    I changed my mind from the last commit. Rather than use `git push`, wanting to use the best practice of specifying the remote and branch in a push, and believing that students will learn parallel forms faster than variations, I have made two recipes for push: one for pushing the feature branch, and one for pushing master.
    StoneyJackson authored Jun 7, 2018
    Configuration menu
    Copy the full SHA
    2eebb9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3d53545 View commit details
    Browse the repository at this point in the history
  4. Add push master to update master recipe

    The goal is to synchronize master with our repositories. So we need to push to origin after pulling from upstream.
    StoneyJackson authored Jun 7, 2018
    Configuration menu
    Copy the full SHA
    1fcc267 View commit details
    Browse the repository at this point in the history
  5. Separate the update push into its own step

    For consistency.
    StoneyJackson authored Jun 7, 2018
    Configuration menu
    Copy the full SHA
    5202e0d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e2dd933 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a401b2e View commit details
    Browse the repository at this point in the history
  8. Remove redundant "form teams"

    From burged
    
    The formation of teams was already a bullet item in the README -- maybe pull that bulleted item from the README -- it makes more sense for the formation of teams to be here.
    StoneyJackson authored Jun 7, 2018
    Configuration menu
    Copy the full SHA
    c291f84 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    adae2ca View commit details
    Browse the repository at this point in the history
  10. Improve directions to faciliator

    Closes #30
    StoneyJackson authored Jun 7, 2018
    Configuration menu
    Copy the full SHA
    5d9feda View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d76b23b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bc7ef82 View commit details
    Browse the repository at this point in the history
  13. Fix grammar

    Closes #33
    StoneyJackson authored Jun 7, 2018
    Configuration menu
    Copy the full SHA
    5b99215 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. Configuration menu
    Copy the full SHA
    769d30f View commit details
    Browse the repository at this point in the history
  2. Fix grammar

    Related to #34
    StoneyJackson authored Jun 8, 2018
    Configuration menu
    Copy the full SHA
    1162d97 View commit details
    Browse the repository at this point in the history
  3. Fix link

    related to #34
    StoneyJackson authored Jun 8, 2018
    Configuration menu
    Copy the full SHA
    4c8f34c View commit details
    Browse the repository at this point in the history
  4. Fix link

    Related to #34
    StoneyJackson authored Jun 8, 2018
    Configuration menu
    Copy the full SHA
    921c98f View commit details
    Browse the repository at this point in the history