Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php82: php82-beta1 -> php82-beta2 #134

Merged
merged 1 commit into from
Aug 10, 2022
Merged

php82: php82-beta1 -> php82-beta2 #134

merged 1 commit into from
Aug 10, 2022

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Aug 7, 2022

No description provided.

@drupol
Copy link
Collaborator Author

drupol commented Aug 7, 2022

That test was not failing in 8.2-beta1

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
pcntl_setpriority() - Check for errors [tests/pcntl_setpriority_error_linux.phpt]
=====================================================================

Find the complete build log here: https://gist.github.com/drupol/a3fd7c7febee964ad595540b32530332

Do you think I should an issue in php/php-src ?

@jtojnar
Copy link
Member

jtojnar commented Aug 7, 2022

First, we need to get the actual test protocol. Build it with nix build .#php82.extensions.pcntl --keep-failed and then look at php-8.2.0beta2/ext/pcntl/php_test_results* in the reported build directory.

@jtojnar
Copy link
Member

jtojnar commented Aug 7, 2022

Another thing you can check is the tests/pcntl_setpriority_error_linux.phpt file in the PHP source code for any recent changes. And the changelog of course.

@drupol
Copy link
Collaborator Author

drupol commented Aug 7, 2022

Another thing you can check is the tests/pcntl_setpriority_error_linux.phpt file in the PHP source code for any recent changes. And the changelog of course.

That file has been introduced in this commit (php/php-src@520bb2e#diff-d517133d2e2c271fcdba556de2330cd984828e7cb14fd42e93a43106aab2b3c2). This test is failing is failing on CI.

@drupol drupol merged commit 91bdb93 into master Aug 10, 2022
@drupol drupol deleted the php82/bump branch August 10, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants