Cannot Star/Unstar : Internal Error

[Keyhaku]

Hi,

I've just met a problem with the star/unstar system, see my nginx log, by uncommenting the line
";always_populate_raw_post_data = -1" in php5.ini i've managed to make it work.

According to php manual (http://php.net/manual/en/ini.core.php), this directive is obsolete from php 5.6 (that the version I'm using).

Regards.

Log

*182 FastCGI sent in stderr: "PHP message: Fatal error: Automatically populating $HTTP_RAW_POST_DATA is deprecated and will be removed in a future version. To avoid this warning set 'always_populate_raw_post_data' to '-1' in php.ini and use the php://input stream instead"

[niol]

I cannot find any obvious usage of $HTTP_RAW_POST_DATA in selfoss. Which version are you using?

[Keyhaku]

Hi,

I'm using the latest version of selfoss (2.12).

Regards.

[niol]

Do you have a line number for the error? I'll try to reproduce when I get the chance to upgrade to PHP 5.6.

[dubbl]

Other open source projects are having the same problem with PHP 5.6 (matomo-org/matomo#6465)

We don't use/access $HTTP_RAW_POST_DATA, the warning occurs during the population of this variable, even before the selfoss code is executed. The warning is caused by an HTTP POST request with a payload other than 'Content-Type: application/x-www-form-urlencoded' (I think the starr/unstarr request has an empty payload, which makes this warning even more weird).

The only "fix" seems to be to downgrade PHP or to set always_populate_raw_post_data to -1 in the php.ini. Here is the PHP bug report https://bugs.php.net/bug.php?id=66763. Apparently even more applications would break if they would set always_populate_raw_post_data to -1 as a default.

[jtojnar]

As temporary fix you can replace line 1757 in libs/f3/base.php

    if ($error=error_get_last())

with

    $ignored = "Automatically populating \$HTTP_RAW_POST_DATA is deprecated and will be removed in a future version. To avoid this warning set 'always_populate_raw_post_data' to '-1' in php.ini and use the php://input stream instead.";
    if ($error=error_get_last() && isset($error) && $error['message']!==$ignored)

The issue is described in detail in this blog post.

Maybe we should also start an issue in https://github.com/bcosca/fatfree

[jtojnar]

Closing since it was fixed in #664. Please open a new issue when it reappears.