Use Guzzle with SimplePIe #1052
Conversation
SimplePie uses custom code for fetching resources from web but this is inconsistent and error-prone. To fix this, we will overload SimplePie’s File class with our own subclass using Guzzle.
For RSS Feeds, we have been adding “Simplepie/X.Y.Z” string to the User-Agent header. Given that this is just an implementation detail, and that many websites actively block SimplePie, we will no longer continue to do so.
jtojnar
force-pushed
the
simplepie-guzzle
branch
from
4e297cc
to
c817b20
Compare
|
Can't we just expose the user agent as: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.75 Safari/537.36 |
In #1052, we introduced a class that allowed us to make SimplePie fetch feeds using Guzzle and then pass headers and content back to it. Unfortunately, SimplePie expects the headers to be lower-case and strings, whereas Guzzle returns original case and string arrays as mandated by PSR-7. This in turn broke autodiscovery. Closes: #1130
|
Just for completeness, the user agent change did not cause this, the other change did. And as for the user agent change, we already are somewhat Chromey. If we should pretend to be Chrome completely is a separate issue. |
Oh, ok, :-) |
SimplePie uses custom code for fetching resources from web but this is inconsistent and error-prone. To fix this, we will be overloading SimplePie’s
Fileclass with our own subclass using Guzzle.Additionally, we will be no longer adding “Simplepie/X.Y.Z” string to the
User-Agentheader. Given that this is just an implementation detail, and that many websites actively block SimplePie.