Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Grunt #1093

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Get rid of Grunt #1093

merged 3 commits into from
Feb 21, 2019

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Feb 20, 2019

A prerequisite to Webpack. (I could not get grunt-webpack task to work.)

Still need to check the zipball is created correctly.

@jtojnar jtojnar added this to the 2.19 milestone Feb 20, 2019
@jtojnar jtojnar requested a review from niol February 20, 2019 17:53
@jtojnar
Copy link
Member Author

jtojnar commented Feb 20, 2019

Makefile might be cleaner solution but I am not sure how available make is on Windows.

In the process of abandoning grunt, let us move the version replacer
to a standalone script and register it with NPM. It can be run as follows:

    npm run bump-version 2.19
Another step in abandoning Grunt
Zipball can now be created using `npm run dist`.
@jtojnar
Copy link
Member Author

jtojnar commented Feb 21, 2019

Okay, the zipball now contains all files the original one did. We also have some extra FTR files starting with dot like vendor/j0k3r/graby-site-config/.wordpress.com.txt which were previously filtered out.

@jtojnar jtojnar marked this pull request as ready for review February 21, 2019 23:46
@jtojnar jtojnar merged commit 4ff722e into master Feb 21, 2019
@jtojnar jtojnar deleted the no-more-grunt branch February 21, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant