Share button for copy #1142
Merged
Share button for copy #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Oct 2, 2019
Co-Authored-By: Jan Tojnar <[email protected]>
Otherwise it will not show when user scrolled down.
jtojnar
force-pushed
the
share_button_for_copy
branch
from
98f278c
to
e7a32ba
Compare
|
Thanks for the help. I switched to a different clipboard library that is closer to the native version. Also changed the icon to a vector one since #1013 got finally merged. |
|
Haha thank you :) , I didn't end up doing much in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1105
Otherwise should be good to go. Tested on Firefox, Chrome both on Linux desktop and android.