Support search using regex #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
regex-search
branch
from
b4d697a
to
2455a7a
Compare
phicha20224
approved these changes
Jan 11, 2021
|
I want to base this onto #1216, which will make it easier to distinguish the search terms in the UI. |
When user searches a term starting and ending with a forward slash, the items will be matched against the regular expression between the slashes. The syntax of the regular expressions is database-engine specific: * MySQL uses POSIX extended https://dev.mysql.com/doc/refman/5.7/en/regexp.html * PostgreSQL uses POSIX extended with some extensions https://www.sqlite.org/lang_expr.html#the_like_glob_regexp_and_match_operators * SQLite uses PHP’s PCRE https://www.postgresql.org/docs/12/functions-matching.html#FUNCTIONS-POSIX-REGEXP, https://www.php.net/manual/en/book.pcre.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user searches a term starting and ending with a forward slash, the items will be matched against the regular expression between the slashes.
The syntax of the regular expressions is database-engine specific:
The filtering works but the interface is still incomplete. In particular, the matches will not be highlighted in the articles, and the search regex will be shown split on spaces.Fixed.