client: Add route for adding RSS sources #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visiting `/manage/sources/add?url=foo` will load the settings page, open the “new source” form and pre-fill the URL specified in the query string parameter. For now, only URL is customizable. Fixes: #254
They are already fetched from the initial loading of sources so we should not need to wait for them to be fetched again. In the rare case that they did indeed change, we can update the select box later. This will significantly speed up opening the “New source” form, especially when using the `/manage/sources/add` route.
I also forgot to add setDirty calls to SourceParam in 3eaf1f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visiting
/manage/sources/add?url=foowill load the settings page, open the “new source” form and pre-fill the URL specified in the query string parameter. For now, only URL is customizable.Fixes: #254