[WIP] Improve accessibility #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some labels and converted most of the action divs/spans into real buttons or tabindexed pseudo-links. Whole interface should be now controllable by keyboard but that can be quite tedious. Later I will try to add more role attributes which should make it much more convenient.
I also don’t know how good is the screen readers’ support for dynamically added elements (the form to add a new source). Maybe I will need to use ARIA live regions.
Search form is hidden beneath the sidebar but it is probably accessible for screen readers, not sure if it is okay. I added search role, is it enough or is a heading needed?
The CSS is a little off but that can be also fixed later.