bugfix & improvements #991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add semaphore locker add cli timeout add db unique key
niol
requested changes
Nov 2, 2017
jtojnar
reviewed
Nov 2, 2017
daos/sqlite/Database.php
Outdated
| @@ -234,6 +234,47 @@ public function __construct() { | |||
| 'INSERT INTO version (version) VALUES (11)' | |||
| ]); | |||
| } | |||
| if (strnatcmp($version, '12') < 0) { | |||
| \F3::get('db')->exec([ | |||
| // Table needs to be re-created because ALTER TABLE is rather limited. | |||
There was a problem hiding this comment.
You should be able to CREATE UNIQUE INDEX https://www.sqlite.org/lang_createtable.html#constraints
jtojnar
reviewed
Nov 2, 2017
cliupdate.php
Outdated
| @@ -1,4 +1,5 @@ | |||
| <?php | |||
| set_time_limit(300); | |||
There was a problem hiding this comment.
Why this time limit? We are already using a greater one in the ContentLoader.
|
|
|
query fixed in 54235f8 |
|
Regarding the locking, in #967 (comment), I actually meant the |
|
Also it would be nice if you could split the unique constraint to a separate commit from the locking part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add semaphore locker
add cli timeout
add db unique key