Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement refresh tokens authentication #2230

Open
iamareebjamal opened this issue Aug 3, 2019 · 10 comments · May be fixed by #2264 or #2349
Open

Implement refresh tokens authentication #2230

iamareebjamal opened this issue Aug 3, 2019 · 10 comments · May be fixed by #2264 or #2349
Labels
Codeheat enhancement open-to-all Priority: High
Milestone
Codeheat 8

Comments

@iamareebjamal
Copy link
Member

iamareebjamal commented Aug 3, 2019 •
edited
Loading

API Docs - https://api.eventyay.com/

By default, users will not be logged out from the site. All needed info on how to implement it is present in Authentication Section of the API doc above. If any doubt, ask me.
@liveHarshit
Copy link
Member

So the following are needs to implement:

  • Logout and Login with server
  • Refresh token (When?)
    And the remember-me attribute is for what?

@iamareebjamal
Copy link
Member Author

No, logout is not required. Read the documentation carefully and some blog on refresh tokens

@anhanh11001 anhanh11001 added this to the Milestone 10: Summer 2019 milestone Aug 4, 2019
@anhanh11001 anhanh11001 mentioned this issue Aug 8, 2019
Closed
@anhanh11001 anhanh11001 added the on hold: server side Needs to solve on the server first label Aug 8, 2019
@liveHarshit
Copy link
Member

@anhanh11001 Why it is on hold from server-side?

@iamareebjamal iamareebjamal removed the on hold: server side Needs to solve on the server first label Aug 8, 2019
@iamareebjamal
Copy link
Member Author

It's not. This is available in dev server, not in production. All client development must be done using development instance of server

@liveHarshit
Copy link
Member

@anhanh11001 Are you working on it or can I take this issue?

@anhanh11001
Copy link
Contributor

@liveHarshit just a little, please take this issue

@liveHarshit liveHarshit self-assigned this Aug 9, 2019
liveHarshit added a commit to liveHarshit/open-event-attendee-android that referenced this issue Aug 9, 2019
@liveHarshit
feat: Implement JWT refresh token for authorization (fossasia#2230)
c681fe1
@liveHarshit liveHarshit linked a pull request Aug 9, 2019 that will close this issue
Open
@liveHarshit liveHarshit added the has-PR Already has a PR and waiting for reviews label Aug 9, 2019
@liveHarshit liveHarshit added this to the Codeheat 4 milestone Sep 15, 2019
@ranjsa
Copy link
Member

ranjsa commented Sep 17, 2019

@liveHarshit Can i work on this issue ?

@anhanh11001
Copy link
Contributor

@ranjsa there is already a PR for this, please work on another issue or try to test the app to see if you can find any bugs to fix or reasonable new features to implement

aggarwalpulkit596 added a commit to aggarwalpulkit596/open-event-android that referenced this issue Sep 18, 2019
@aggarwalpulkit596
feat: Implement JWT refresh token for authorization (fossasia#2230)
1c4eca0
@aggarwalpulkit596 aggarwalpulkit596 linked a pull request Sep 18, 2019 that will close this issue
Open
aggarwalpulkit596 added a commit to aggarwalpulkit596/open-event-android that referenced this issue Sep 18, 2019
@aggarwalpulkit596
feat: Implement JWT refresh token for authorization (fossasia#2230)
67c2390
aggarwalpulkit596 added a commit to aggarwalpulkit596/open-event-android that referenced this issue Sep 18, 2019
@aggarwalpulkit596
feat: Implement JWT refresh token for authorization (fossasia#2230)
adfc7ca
aggarwalpulkit596 added a commit to aggarwalpulkit596/open-event-android that referenced this issue Sep 18, 2019
@aggarwalpulkit596
feat: Implement JWT refresh token for authorization (fossasia#2230)
52a6cf2
aggarwalpulkit596 added a commit to aggarwalpulkit596/open-event-android that referenced this issue Sep 18, 2019
@aggarwalpulkit596
feat: Implement JWT refresh token for authorization (fossasia#2230)
3f25fc2
aggarwalpulkit596 added a commit to aggarwalpulkit596/open-event-android that referenced this issue Sep 19, 2019
@aggarwalpulkit596
feat: Implement JWT refresh token for authorization (fossasia#2230)
71a1d31
@liveHarshit liveHarshit modified the milestones: Codeheat 4, Codeheat 8 Oct 17, 2019
@liveHarshit liveHarshit added Priority: High open-to-all and removed has-PR Already has a PR and waiting for reviews labels Sep 15, 2020
@liveHarshit liveHarshit removed their assignment Sep 15, 2020
@spacemonkey1101
Copy link

i would like to work on this if assigned

@liveHarshit
Copy link
Member

@spacemonkey1101 Take one issue at once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Codeheat enhancement open-to-all Priority: High
Projects
None yet
Milestone
Codeheat 8
6 participants
@mariobehling @iamareebjamal @liveHarshit @anhanh11001 @spacemonkey1101 @ranjsa