Converted classes to Kotlin #2405
Conversation
|
Hi @sriramr98! It looks like one or more of your builds have failed.
|
|
@iamareebjamal is JCenter down again? |
| @@ -85,15 +85,15 @@ object Utils { | |||
| if (isBaseUrlEmpty) { | |||
| swipeRefreshLayout.isEnabled = false | |||
| } else { | |||
| StrategyRegistry.instance.eventBusStrategy!!.eventBus.register(`object`) | |||
| StrategyRegistry.instance.eventBusStrategy?.getEventBus()?.register(`object`) | |||
There was a problem hiding this comment.
Because I could not set a default getter implementation because the getter referenced the eventBus and that turned into infinite recursion. So I had to create an explicit getEventBus method
There was a problem hiding this comment.
Why would it recur? That doesn't make sense
There was a problem hiding this comment.
For some reason, accessing the property from inside the getter calls the getter again.
There was a problem hiding this comment.
Why are you accessing it inside getter, of course it will recur that way
It's like saying
int getAge() {
return getAge();
}There was a problem hiding this comment.
Yeah, android studio showed the error. But I found a solution using the 'field' naming.
There was a problem hiding this comment.
Becuase we need to do this
if (field == null) {
field = Bus()
}
return field
There was a problem hiding this comment.
We don't need the lazy approach here. We can just use the field attribute.
|
|
||
| StrategyRegistry.instance | ||
| .eventBusStrategy!! | ||
| .postEventOnUIThread(BookmarkChangedEvent()) |
First steps for issues #2357
Changes: Converted classes to Kotlin.