chore: Finally remove @open-event/theme

[iamareebjamal]

Fixes #4526

Since we have reverted to rounded corners and undone any changes to default semantic theme, there is no use of depending on fork of semantic UI theme as it is difficult to maintain and causes random undebuggable bugs like the one linked.

To be fixed before merged:

• Modals are not showing up correctly

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6vk3bxie4
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-opev-theme-remove.eventyay.vercel.app

[codecov]

Codecov Report

Merging #4538 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #4538   +/-   ##
============================================
  Coverage        23.09%   23.09%           
============================================
  Files              476      476           
  Lines             4979     4979           
  Branches             8        8           
============================================
  Hits              1150     1150           
  Misses            3828     3828           
  Partials             1        1           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d01005...769d985. Read the comment docs.

[iamareebjamal]

Still having issues with fomantic UI for modals. Will diagnose more what can be done

[kushthedude]

@iamareebjamal Won't we want to update the open-event theme to use fomantic & then refer it here like it was done in case of semantic-ui?

[iamareebjamal]

Why would we depend on an indirection and maintain another package when we aren't changing anything? And then update 2 packages when there is an update to fomantic UI and make a release in open even theme?

[kushthedude]

Why would we depend on an indirection and maintain another package when we aren't changing anything? And then update 2 packages when there is an update to fomantic UI and make a release in open even theme?

Makes sense, but I thought we would want it to maintain the open-event ecosystem.

[iamareebjamal]

Why? Any reason?

[kushthedude]

Why? Any reason?

I thought we would want to maintain the open-event ecosystem including the design system too, so next if I someone would need fomantic-ember they can see the open-event-theme.

[iamareebjamal]

There is no open-event theme. It is exactly same as default semantic UI theme. Just rounded corners were removed and now have been restored

[iamareebjamal]

We can't use fomantic UI unless fomantic/Fomantic-UI#811 is resolved

[iamareebjamal]

This is the reason for scroll block Semantic-Org/Semantic-UI#6449

[iamareebjamal]

This commit fixes the issue https://github.com/fomantic/Fomantic-UI/pull/273/files but the latest code https://raw.githubusercontent.com/fomantic/Fomantic-UI/master/src/definitions/modules/modal.js causes this issue fomantic/Fomantic-UI#1590 which is not reproducible in a minimal example

So, merging for now. Will find proper solution after more debugging

[iamareebjamal]

If no solution is found, then we'll patch our own code with the PR so that both scrolling issue and modals dismissal is fixed