Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-8980: Badge creation in wizard misses default options #8994

Merged
merged 17 commits into from Aug 2, 2023
Merged

feature-8980: Badge creation in wizard misses default options #8994

merged 17 commits into from Aug 2, 2023

Conversation

khangon
Copy link
Contributor

@khangon khangon commented Jul 24, 2023

Fixes #8980

Short description of what this resolves:

Changes proposed in this pull request:

  • add default value when create new badge

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-event-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 4:24am

@khangon
Copy link
Contributor Author

khangon commented Aug 1, 2023

Hi @norbusan , @mariobehling , @cweitat ,
We have completed ticket #8980
Please help me check and verify.
Thanks,
Screenshot from 2023-08-01 19-32-29
Screenshot from 2023-08-01 19-33-25

@khangon khangon marked this pull request as ready for review August 1, 2023 12:35
@mariobehling mariobehling merged commit bedd612 into fossasia:development Aug 2, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge creation in wizard misses default options
3 participants