-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors Theme Component and increase coverage #1340
Merged
praveenojha33
merged 1 commit into
fossasia:development
from
shreyanshdwivedi:refactorTheme
Jan 21, 2019
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,50 @@ | ||
<div class="modal-dialog" role="document"> | ||
<div class="modal-content"> | ||
|
||
<div class="modal-header"> | ||
<!-- Start ignoring HTMLLintBear --> | ||
<button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> | ||
<!-- Stop ignoring HTMLLintBear --> | ||
<button | ||
type="button" | ||
class="close" | ||
data-dismiss="modal" | ||
aria-label="Close" | ||
><span aria-hidden="true">×</span | ||
></button> | ||
<h4 class="modal-title" id="my-modal-label">Customization</h4> | ||
<button type="button" (click)="setTheme('defaultTheme')" class="btn btn-round btn-default theme-link" id="default">Default</button> | ||
<button type="button" (click)="setTheme('darkTheme')" class="btn btn-round btn-default theme-link" id="dark">Dark</button> | ||
<button type="button" (click)="setTheme('basicTheme')" class="btn btn-round btn-default theme-link" id="basic">Basic</button> | ||
<button type="button" (click)="setTheme('contrastTheme')" class="btn btn-round btn-default theme-link" id="contrast">Contrast</button> | ||
<button type="button" (click)="setTheme('terminalTheme')" class="btn btn-round btn-default theme-link" id="terminal">Terminal</button> | ||
<button type="button" (click)="setTheme('nightTheme')" class="btn btn-round btn-default theme-link" id="night">Night</button> | ||
<button | ||
type="button" | ||
(click)="setTheme('defaultTheme')" | ||
class="btn btn-round btn-default theme-link" | ||
id="default" | ||
>Default</button> | ||
<button | ||
type="button" | ||
(click)="setTheme('darkTheme')" | ||
class="btn btn-round btn-default theme-link" | ||
id="dark" | ||
>Dark</button> | ||
<button | ||
type="button" | ||
(click)="setTheme('basicTheme')" | ||
class="btn btn-round btn-default theme-link" | ||
id="basic" | ||
>Basic</button> | ||
<button | ||
type="button" | ||
(click)="setTheme('contrastTheme')" | ||
class="btn btn-round btn-default theme-link" | ||
id="contrast" | ||
>Contrast</button> | ||
<button | ||
type="button" | ||
(click)="setTheme('terminalTheme')" | ||
class="btn btn-round btn-default theme-link" | ||
id="terminal" | ||
>Terminal</button> | ||
<button | ||
type="button" | ||
(click)="setTheme('nightTheme')" | ||
class="btn btn-round btn-default theme-link" | ||
id="night" | ||
>Night</button> | ||
</div> | ||
|
||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to use
then
? Can't it be done without it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually whatever reference I got about
whenStable
withasync
, I found the same format. I don't think it'll work without this