Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes active theme button different from others #1342

Merged
merged 1 commit into from
Dec 26, 2018

Conversation

shreyanshdwivedi
Copy link
Member

Fixes #1341

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

  • Applied css to the active theme button. I have changes background color of the active theme button. The color used is our theme color which is used throughout project

screenshot_2018-12-23 susper - decentral search engine 1

@codecov
Copy link

codecov bot commented Dec 23, 2018

Codecov Report

Merging #1342 into development will decrease coverage by 0.34%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1342      +/-   ##
===============================================
- Coverage        54.89%   54.55%   -0.35%     
===============================================
  Files               51       51              
  Lines             1419     1428       +9     
  Branches           176      177       +1     
===============================================
  Hits               779      779              
- Misses             534      543       +9     
  Partials           106      106
Impacted Files Coverage Δ
src/app/theme/theme.component.ts 13.97% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cf69e...80e91d0. Read the comment docs.

@shreyanshdwivedi
Copy link
Member Author

shreyanshdwivedi commented Dec 23, 2018

@AakashMallik @praveenojha33 @simsausaurabh please review :)
Coverage is decreasing because I've added function for which test will be added in PR #1340

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Please provide tests ASAP.

@shreyanshdwivedi
Copy link
Member Author

@praveenojha33 please merge this, so that I can include it in my PR having tests

@praveenojha33 praveenojha33 merged commit 40df564 into fossasia:development Dec 26, 2018
@shreyanshdwivedi shreyanshdwivedi deleted the activeTheme branch December 28, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the selected theme button active in the Theme Component
3 participants