Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled text and number property inputs by removing keypress preventDefault() calls interfering from unrelated panes. #936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tripp528
Copy link

Description

Commented out some preventDefault calls on keypress events that were being called from panes that weren't the target for the event.

Motivation and Context

Text and number property inputs were not functioning when a separate embeddings, text, or image pane was present and had a keypress callback handler registered to it.

Fixes #935

@tripp528
Copy link
Author

I'm not sure what those preventDefault() calls were meant for exactly, but this doesn't seem to have introduced any issues thus far. A cleaner fix might be to check if e.g. the ImagePane was the target before calling preventDefault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text and number input properties not working
1 participant