-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow multiple compiler configs #170
Open
klkvr
wants to merge
19
commits into
main
Choose a base branch
from
klkvr/settings-profiles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/settings-profiles
branch
from
August 13, 2024 20:13
55fbc56
to
c269a7d
Compare
klkvr
force-pushed
the
klkvr/settings-profiles
branch
from
August 28, 2024 00:19
b9e5f7f
to
9b13ed2
Compare
klkvr
force-pushed
the
klkvr/settings-profiles
branch
from
September 10, 2024 16:19
9d6a8b8
to
2e82dc5
Compare
klkvr
force-pushed
the
klkvr/settings-profiles
branch
from
September 23, 2024 18:08
2e82dc5
to
1b80617
Compare
klkvr
force-pushed
the
klkvr/settings-profiles
branch
from
November 6, 2024 00:26
1b80617
to
5b42d05
Compare
klkvr
force-pushed
the
klkvr/settings-profiles
branch
2 times, most recently
from
November 6, 2024 02:20
0c2f7d8
to
26a2657
Compare
mattsse
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of this makes sense,
was able to follow, but could use some additional docs
Comment on lines
8
to
10
pub trait CompilerSettingsRestrictions: Copy + Debug + Sync + Send + Clone + Default { | ||
fn merge(self, other: Self) -> Option<Self>; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs docs
klkvr
changed the title
[wip] feat: allow multiple compiler configs
feat: allow multiple compiler configs
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
CompilerSettings::Restrictions
associated type which allows configuring constraints for compilation settings. Those constraints can be checked against a settings object and merged.Ideally given a set of constraints we'd be able to automatically resolve configurations given only basic (default) config, though I think we can do this in follow-up. Current implementation requires user to provide us with concrete profiles such that for each defined constraint at least one of the profiles matches it. This should be enough for most of the usecases for now.
Profile to use is resolved in
Graph
similarly to version resolution.The way this could look in foundry.toml is:
When writing artifacts, a profile name is added to artifact file name if the same contract was compiled with multiple artifacts.