Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snapshots directory #192

Closed
wants to merge 3 commits into from
Closed

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Aug 30, 2024

This directory holds gas snapshots that users would usually want to check into their git

Required for foundry-rs/foundry#8755 (foundry-rs/foundry#2065)

@klkvr
Copy link
Member

klkvr commented Aug 31, 2024

hmm, I think we can keep this on foundry's Config? given that it's just an internal cheatcode configuration unrelated to compilation

@zerosnacks zerosnacks marked this pull request as draft September 2, 2024 09:32
@zerosnacks
Copy link
Member Author

hmm, I think we can keep this on foundry's Config? given that it's just an internal cheatcode configuration unrelated to compilation

Fair point, moving to draft for now - seeing if I can implement this in an elegant way directly in Foundry

@zerosnacks
Copy link
Member Author

zerosnacks commented Sep 2, 2024

Added directly in Foundry, closing

@zerosnacks zerosnacks closed this Sep 2, 2024
@zerosnacks zerosnacks deleted the zerosnacks/snapshots branch September 2, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants