Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten fix #68

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Flatten fix #68

merged 4 commits into from
Feb 2, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Feb 1, 2024

Ref foundry-rs/foundry#6936 (comment)

Not sure why exactly this unwrap is failing, adding None variant handling and some logs to debug it.

@klkvr klkvr requested review from mattsse, Evalir and DaniPopes and removed request for Evalir and DaniPopes February 1, 2024 16:19
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic nits

src/flatten.rs Outdated
Comment on lines 464 to 465
match new_name {
Some(new_name) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use if let Some else

src/flatten.rs Outdated Show resolved Hide resolved
klkvr and others added 2 commits February 2, 2024 14:25
@mattsse mattsse merged commit 7b23450 into foundry-rs:main Feb 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants