Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom cache key and cache restore key input #47

Merged
merged 10 commits into from
Mar 1, 2024

Conversation

penandlim
Copy link
Contributor

Closes #33

  • Add two new inputs, cache-key and cache-restore-keys
  • Default cache key now includes job.id
  • Update README.md with examples

src/cache.js Outdated
Comment on lines 18 to 25
const defaultRestoreKeys = [prefix];
const customRestoreKeyInput = core
.getInput("cache-restore-keys")
.split(/[\r\n]/)
.map((input) => input.trim())
.filter((input) => input !== "")
.map((input) => `${prefix}${input}`);
const restoreKeys = customRestoreKeyInput.concat(defaultRestoreKeys);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move this out to a fn for readability

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for late turnaround on this, and thank you!

@onbjerg onbjerg merged commit 8f1998e into foundry-rs:master Mar 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to configure rpc caching
2 participants