Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fmt): format struct (restoring fields from source for now) #1318

Merged
merged 3 commits into from
Apr 15, 2022
Merged

feat(fmt): format struct (restoring fields from source for now) #1318

merged 3 commits into from
Apr 15, 2022

Conversation

shekhirin
Copy link
Contributor

Motivation

Baby steps

Solution

Implement struct formatting with copying fields from source code (for now)

@shekhirin shekhirin marked this pull request as ready for review April 15, 2022 21:05
mattsse
mattsse approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

merge now?

also fyi #889

@shekhirin
Copy link
Contributor Author

@mattsse yeah, I think we can merge now. Fields require more work because of comments and line breaks due to long definitions that can occur.

regarding #889: yep I've seen it, nice! Will try to help as much as I can 😄

@mattsse mattsse merged commit a84a281 into foundry-rs:master Apr 15, 2022
@onbjerg onbjerg added the T-feature Type: feature label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @mattsse @onbjerg