Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anvil): use base fee of fork by default #1865

Merged
merged 3 commits into from
Jun 11, 2022
Merged

fix(anvil): use base fee of fork by default #1865

merged 3 commits into from
Jun 11, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jun 7, 2022 •
edited
Loading

Motivation

Closes #1863

  • use last base fee and current gas price retrieved from the endpoint
  • adjust default gas price settings to match hh instead of ganache

needs follow-up to change the eth_gasPrice endpoint to match: ethereum/pm#328 (comment)

Solution

use the base fee of the last fork block by default if not provided via cli

@mattsse mattsse added the C-anvil Command: anvil label Jun 7, 2022
@mattsse mattsse mentioned this pull request Jun 7, 2022
Closed
2 tasks
@mattsse mattsse marked this pull request as draft June 7, 2022 18:33
@mattsse mattsse closed this Jun 7, 2022
@mattsse mattsse reopened this Jun 10, 2022
@mattsse mattsse marked this pull request as ready for review June 10, 2022 19:14
@mattsse mattsse added the T-bug Type: bug label Jun 10, 2022
@gakonst gakonst merged commit 64998a3 into foundry-rs:master Jun 11, 2022
@gakonst
Copy link
Member

gakonst commented Jun 11, 2022

The eth_gasPrice API change seems unrelated to the bug right?

@mattsse
Copy link
Member Author

mattsse commented Jun 11, 2022

yeh will track in new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
C-anvil Command: anvil T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base fee causes error in forked Rinkeby network on first transaction
2 participants
@mattsse @gakonst