Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cheatcodes): restrict cheatcode usage on precompiles #4905

Merged
merged 4 commits into from
May 10, 2023

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented May 9, 2023

Motivation

Closes #1159.

Solution

Restricts certain cheatcodes on precompile addresses (etch, load, store, deal).

Some convo remains if we also wanna restrict the other addresses mentioned in the issue & if we wanna restrict prank:

address(0xCe71065D4017F316EC606Fe4422e11eB2c47c246), // FuzzerDict
address(0x4e59b44847b379578588920cA78FbF26c0B4956C), // CREATE2 Factory (?)
address(0xb4c79daB8f259C7Aee6E5b2Aa729821864227e84), // address(this)
address(0x185a4dc360CE69bDCceE33b3784B0282f7961aea), // default sender account
address(0x7109709ECfa91a80626fF3989D68f67F5b1DD12D) // cheatcodes addr```

@Evalir Evalir requested review from mattsse and mds1 May 9, 2023 00:05
@mds1
Copy link
Collaborator

mds1 commented May 9, 2023

Agree with changing this for etch, load, and store since none of those are realistic for precompiles. But precompiles can hold ETH so we might want to leave deal alone and not disable that one

@Evalir Evalir requested a review from mds1 May 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow some cheatcodes for precompiles
3 participants