Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified git fetch command to method to use correct root folder. #6119

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

janbro
Copy link
Contributor

@janbro janbro commented Oct 26, 2023

Motivation

#6108
Forge init --template fails when passing a directory that's different than the CWD since a git command is not ran in the correct context.

Solution

Change Git::fetch to a method and use the context from the instantiate Git object

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, test looks fine,

pending @Evalir

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good

@DaniPopes DaniPopes merged commit 93f64c7 into foundry-rs:master Oct 26, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants