fix(forge): add coverage to test setUp #6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
reviewed
Oct 31, 2023
Evalir
requested changes
Oct 31, 2023
Inphi
force-pushed
the
inphi/setup-cov
branch
from
7809b1d
to
f49caaf
Compare
|
@Evalir Thanks for the review. PR's been rebased and I've added lcov generated reports of the changes to the PR description. |
Evalir
approved these changes
Nov 2, 2023
mattsse
approved these changes
Nov 3, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve forge coverage reporting of functions called during test
setUp. This allows initializer functions, but not ctors, called during setUp (ex: #4553) to be covered.Solution
The
TestSetupis extended to include coverage info. ThesetUpcoverage is then merged withHitMapsgenerated by test runners.Consider the coverage reporting of the
CounterTest:test_Incrementtest generated byforge init. Prior to this change, we see thatCounter.setNumberisn't covered because it's only called duringsetUp:With this patch, we get full test coverage in
Counter.sol: