fix(cheatcodes): return early in case of reverts to not conflict with expect* logic
#6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Oct 30, 2023
|
fyi @DaniPopes merging this because critical |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6170.
The bug was caused by the logic around detecting unmatched calls/events when the root test call is terminating. The unrelated
revertwas causing the revert reason to be completely unrelated to what actually caused the real revert, which was visible if the verbosity was increased.We should actually early return at depth 0 before running any
vm.expect*cheatcode logic as if not we'll polute the revert reason with something else.