chore: dedup abi values formatting, cleanups #6196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 2, 2023
| } | ||
|
|
||
| impl<'a> DynValueDisplay<'a> { | ||
| /// Creates a new [`Display`] wrapper for the given value. |
| impl<'a> From<Cow<'a, str>> for ProviderBuilder { | ||
| fn from(url: Cow<'a, str>) -> Self { | ||
| url.as_ref().into() | ||
| Ok(provider) | ||
| } | ||
| } |
There was a problem hiding this comment.
I guess these were never used and since we're transitioning to alloy, makes sense to get rid of them
| @@ -254,7 +233,7 @@ impl<'a> From<Cow<'a, str>> for ProviderBuilder { | |||
| pub async fn estimate_eip1559_fees<M: Middleware>( | |||
| provider: &M, | |||
| chain: Option<u64>, | |||
| ) -> eyre::Result<(U256, U256)> | |||
| ) -> Result<(U256, U256)> | |||
There was a problem hiding this comment.
personally, I prefer the eyre:: prefix, but because there are no other result types, and this is more or less the default result across the codebase, makes sense
DaniPopes
changed the title
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus cleanups