refactor(cheatcodes): rewrite string parsing with dyn abi #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/dyn-cheatcodes
branch
from
007d3d1
to
9d1c31c
Compare
DaniPopes
force-pushed
the
dani/dyn-cheatcodes
branch
from
9d1c31c
to
8cab89f
Compare
mattsse
requested changes
Nov 9, 2023
Comment on lines
+134
to
+135
| "1" => true, | ||
| "0" => false, |
Evalir
approved these changes
Nov 9, 2023
| } | ||
|
|
||
| // More lenient parsers than `coerce_str`. | ||
| fn parse_value_fallback(s: &str, ty: &DynSolType) -> Option<Result<DynSolValue, &'static str>> { |
mattsse
requested changes
Nov 9, 2023
|
Done |
|
CI very flaky |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static encoder is too inflexible for this task. We can still use it for defaults tho.
Closes #6070
Closes #6268
Closes #6265 via alloy-rs/core#410