test: cache global template build at initialization #6299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 13, 2023
Comment on lines
+79
to
+87
| // We are the first to acquire the lock: | ||
| // - initialize a new empty temp project; | ||
| // - run `forge init`; | ||
| // - run `forge build`; | ||
| // - copy it over to the global template; | ||
| // Ideally we would be able to initialize a temp project directly in the global template, | ||
| // but `TempProject` does not currently allow this: https://github.com/foundry-rs/compilers/issues/22 | ||
|
|
||
| // Release the read lock and acquire a write lock, initializing the lock file. |
There was a problem hiding this comment.
ah yeah we should have thought about this much earlier lol
There was a problem hiding this comment.
The problem is that the static Lazy didn't work due to nextest running each test in a separate process
DaniPopes
force-pushed
the
dani/test-global-cache
branch
from
d334b11
to
e10248b
Compare
|
Solidity version used:
Now down to:
|
Evalir
approved these changes
Nov 13, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Faster tests
Solution
Build only once at global template initialization rather than per each test.
This requires that we also use a single Solc version for all tests, at least by default. Do that.