Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove cheatcodes Abigen #6379

Merged
merged 5 commits into from
Nov 21, 2023
Merged

refactor: remove cheatcodes Abigen #6379

merged 5 commits into from
Nov 21, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 20, 2023

Motivation

Part 1/X of removing foundry-abi.

Requires alloy-rs/core#422

Only differences are parameter names and state mutability are taken from input, rather than default; full diff between generated JSON ABIs (git diff file): json_abi_diff.txt

Solution

@DaniPopes DaniPopes marked this pull request as ready for review November 20, 2023 23:33
@DaniPopes DaniPopes marked this pull request as draft November 20, 2023 23:41
@DaniPopes DaniPopes marked this pull request as ready for review November 21, 2023 00:36
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code good

(func.selector(), vec![func])
})
.map(|func| func.clone().to_alloy())
.chain(Vm::abi::functions().into_values().flatten())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that was simple

@DaniPopes DaniPopes merged commit c0a9975 into master Nov 21, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/rm-abigen-cheats branch November 21, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants