-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add --encoded-constructor-args
to verify-contract
as alias for --constructor-args
#6454
chore: add --encoded-constructor-args
to verify-contract
as alias for --constructor-args
#6454
Conversation
I dont think the two commands' flags are the same even if they have the same name |
So what you purpose for? Considering:
vs:
Related previous PR: #622 Why does the behavior of |
verify-contract accepts the already-encoded arguments in one hex string, while script accepts the human-readable form that you would use anywhere else, so I'd rather change the verify-contract behavior. |
Is it better to change the argument name to be more explicit? e.g. |
@Leechael changing them would be a breaking change and we'd rather avoid this—but we can add an alias and recommend that instead. wdyt @DaniPopes / @mattsse ? |
If we can reach a conclusion, I would like to follow the decision and making that change. |
@Leechael I believe the way forward is just add an alias to |
forge verify-contract
argument parsing--encoded-constructor-args
to verify-contract
as alias for --constructor-args
hey @Leechael—added the change I described and changed the PR name—thanks! |
Related: #6453