Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect --offline in etherscan identifier #6801

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: respect --offline in etherscan identifier #6801

merged 1 commit into from
Jan 15, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 15, 2024

closes #6793

Evalir
Evalir approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many feature flags...

@mattsse mattsse merged commit 7c9507b into foundry-rs:master Jan 15, 2024
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High-verbosity Forge tests run with --offline still make network requests to Etherscan and OpenChain
2 participants
@mattsse @Evalir